Skip to content

Commit

Permalink
remove PR gating
Browse files Browse the repository at this point in the history
  • Loading branch information
Manishearth committed Nov 22, 2022
1 parent 9997d21 commit eb5c0c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,8 @@ jobs:

# We don't expect to keep being clippy-clean on nightly Rust,
# so the "toolchain boilerplate" is deliberately omitted
# This just means we end up testing on the pinned stable even in the cronjob
# CI, which isn't that useful but specially omitting that task is more work than it's worth

# Clippy job > Install and run clippy steps
- name: Install clippy
Expand Down
3 changes: 1 addition & 2 deletions Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ if not ${event_name}
end
is_schedule = eq "${event_name}" "schedule"
is_pr = eq "${event_name}" "pull_request"
is_dispatch = eq "${event_name}" "workflow_dispatch"
dispatch_needs_nightly = set false
Expand All @@ -207,7 +206,7 @@ if is_dispatch
end
end
if ${is_schedule} or ${is_pr} or ${dispatch_needs_nightly}
if ${is_schedule} or ${dispatch_needs_nightly}
echo "Setting up CI environment for forced-nightly Rust build"
appendfile ${env_file} "ICU4X_NIGHTLY_TOOLCHAIN=nightly\n"
appendfile ${env_file} "INSTALLED_NIGHTLY_VERSION=nightly\n"
Expand Down

0 comments on commit eb5c0c8

Please sign in to comment.