Restructure AsVarULE or get rid of it #1078
Labels
blocked
A dependency must be resolved before this is actionable
C-data-infra
Component: provider, datagen, fallback, adapters
S-medium
Size: Less than a week (larger bug fix or enhancement)
Milestone
Part of #1082
Depends on #1065
Currently AsVarULE has an
as_unaligned()
that imposes the requirement that AsVarULE types contian their VarULE counterparts somehow. This is fine for the current set of VarULE types, but in general does not work for e.g. custom VarULE types likeWe currently only require
as_unaligned()
for thePartialEq
implementation, which we can get around by adding some comparison methods toAsVarULE
.At a more fundamental level, it's worth considering if
AsVarULE
is worth it in the first place:VarZeroVec<str>
might be just as convenient. We only needAsULE
forZeroVec
for convenient conversions, butVarZeroVec
promises to provide usable values for a lot of its use cases. Perhaps it is better to get rid of the distinction entirely.cc @zbraniecki @sffc
This is needed by @zbraniecki for #615
The text was updated successfully, but these errors were encountered: