Remove AsVarULE

[Manishearth]

Fixes #1078

This gets rid of AsVarULE, getting everyone to work off of the unsized VarULE types directly.

This makes ZeroVec and VarZeroVec a bit asymmetric, ZeroVec takes AsULE types and internally stores them as ULE, performing convenient conversions at the boundary. OTOH, VarZeroVec now directly takes VarULE types, which in the case of str and [u8] are quite convenient to work with already, but less so for types like VarZeroVecULE. This is kinda fine: because ULE types can be held on the stack, ZeroVec actually can make an attempt to do basically free conversions at the boundary, OTOH VarZeroVec must use owned values to do the same thing, and this can be a little expensive.

The major changes here:

• All VarZeroVecFoo types now take T: VarULE
• VarZeroVec::to_vec() returns `Box
• Deserialization of VarZeroVec requires Box<T> implement Deserialize
• ZeroMap operates on references in more place.
• ZeroMap::replace()/ZeroMap::remove() and ZeroMap::insert() return Box<T> for the old value

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• utils/zerovec/src/map/vecs.rs is different
• utils/zerovec/src/ule/mod.rs is different
• utils/zerovec/src/varzerovec/owned.rs is different
• utils/zerovec/src/varzerovec/serde.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[Manishearth]

(Rebased over #1127)

[sffc]

Very nice! I really like the new looks of VarZeroVec!

[sffc]

Request: please approve and merge #1121 before merging this one, since there may be merge conflicts, and it is probably easier to resolve them in that direction. Thank you!

[sffc]

Post-commit LGTM