Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the provider performs correct Norwegian macrolanguage fallback #1963

Closed
hsivonen opened this issue May 30, 2022 · 4 comments · Fixed by #2250
Closed

Ensure that the provider performs correct Norwegian macrolanguage fallback #1963

hsivonen opened this issue May 30, 2022 · 4 comments · Fixed by #2250
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters

Comments

@hsivonen
Copy link
Member

Ensure that requesting the collation for nn or nb loads the collation for no. (Also check nn-NO and nb-NO to see that ignoring more specific but irrelevant tags works in the context of macrolanguage fallback.)

@hsivonen hsivonen added the C-data-infra Component: provider, datagen, fallback, adapters label May 30, 2022
@hsivonen hsivonen added this to the ICU4X 1.0 (Features) milestone May 30, 2022
@hsivonen
Copy link
Member Author

CC @sffc

@hsivonen
Copy link
Member Author

The macrolanguage fallback isn't in CLDR's collation files but assumes knowledge of the Macrolanguage: field in the language subtag registry.

@hsivonen hsivonen changed the title Ensure that the provider performs collect Norwegian macrolanguage fallback Ensure that the provider performs correct Norwegian macrolanguage fallback May 30, 2022
@hsivonen
Copy link
Member Author

There are other macrolanguage relationships in the language subtag registry that fall back to languages with non-root collations, particularly ar and sq. OTOH, the relationship between Serbian, Bosnian, and Croatian collations is handled by a combination of imports and aliases in CLDR.

@sffc sffc self-assigned this Jun 7, 2022
@sffc
Copy link
Member

sffc commented Jun 16, 2022

The nn/nb/no mappings are in the CLDR parent locales:

So this should work by default (as soon as the rest of #1109 is fully implemented). I will add a test specific for collator and then close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants