Add Norwegian collator test #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
approved these changes
Jul 26, 2022
robertbastian
previously approved these changes
Jul 27, 2022
Comment on lines
213
to
216
| match Collator::try_new(&provider, locale!("nb"), CollatorOptions::new()) { | ||
| Ok(_) => panic!("Should fail to create 'nb' without fallback enabled"), | ||
| Err(_) => (), | ||
| }; |
There was a problem hiding this comment.
Clippy wants to make this an if let, but you can use expect_err:
Suggested change
| match Collator::try_new(&provider, locale!("nb"), CollatorOptions::new()) { | |
| Ok(_) => panic!("Should fail to create 'nb' without fallback enabled"), | |
| Err(_) => (), | |
| }; | |
| Collator::try_new(&provider, locale!("nb"), CollatorOptions::new()) | |
| .expect_err("Should fail to create 'nb' without fallback enabled"); |
There was a problem hiding this comment.
expect_err didn't work because Collator does not implement Debug (and I'm not interested in scope-creeping this PR to add such an impl)
There was a problem hiding this comment.
Understandable, although I believe we've said that all public types should be Debug, another thing we need to track before 1.0...
There was a problem hiding this comment.
Is there a way to track this with Clippy or some other way?
There was a problem hiding this comment.
There's a missing_debug_implementations rustc lint
Manishearth
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1963