Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Unicode Extension Keywords to ShortVec and improve macro #2191

Closed
sffc opened this issue Jul 16, 2022 · 2 comments · Fixed by #2382
Closed

Migrate Unicode Extension Keywords to ShortVec and improve macro #2191

sffc opened this issue Jul 16, 2022 · 2 comments · Fixed by #2382
Assignees
@pdogr
Labels
C-locale Component: Locale identifiers, BCP47 good first issue Good for newcomers help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement) T-enhancement Type: Nice-to-have but not required

Comments

@sffc
Copy link
Member

sffc commented Jul 16, 2022

Forked from #1800 to cover Unicode extension keywords.

We should be able to write:

locale!("en-US-u-ca-buddhist")
@sffc sffc added T-enhancement Type: Nice-to-have but not required good first issue Good for newcomers help wanted Issue needs an assignee backlog C-locale Component: Locale identifiers, BCP47 S-medium Size: Less than a week (larger bug fix or enhancement) labels Jul 16, 2022
@yzhang1994
Copy link
Contributor

@sffc Quick question: similar to the variants, I believe there should be some limitations on what we can parse in a const context. Will the locale macro only support a single unicode key value pair? What about other parts of Extensions e.g. Transform, Private? Unicode Attributes?

@sffc
Copy link
Member Author

sffc commented Jul 25, 2022

Good question; I want to start with just unicode::Keywords because those are the most common requirement. The other items can be added later if they are needed.

@pdogr pdogr mentioned this issue Aug 9, 2022
Merged
@robertbastian robertbastian assigned pdogr and unassigned robertbastian Aug 11, 2022
@pdogr pdogr mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdogr pdogr

Labels
C-locale Component: Locale identifiers, BCP47 good first issue Good for newcomers help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement) T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable locale macro to support single unicode key value pair extension pdogr/icu4x
4 participants
@sffc @robertbastian @yzhang1994 @pdogr