Enable locale macro to support single unicode key value pair extension
#2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construct Unicode manually at call site
Rename `LiteMap::from_store_unchecked` to `LiteMap::from_sorted_store_unchecked` Use `Unicode::single_unicode` when some keyword is parsed
with `from_sorted_store_unchecked` Regenerate testdata files using `cargo make testdata`
robertbastian
previously approved these changes
Aug 18, 2022
sffc
reviewed
Aug 18, 2022
Co-authored-by: Shane F. Carr <shane@unicode.org>
Add comment of sorted store in Litemap::from_sorted_store_unchecked
sffc
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2/2 to fix #2191