Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from runtime parsing to compile time parsing #2406

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

pdogr
Copy link
Contributor

@pdogr pdogr commented Aug 18, 2022

Follow-up to #2382

@pdogr pdogr marked this pull request as ready for review August 18, 2022 19:31
@pdogr pdogr requested review from robertbastian and sffc August 18, 2022 19:33
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two suggestions that apply across all the files

components/calendar/src/any_calendar.rs Outdated Show resolved Hide resolved
components/datetime/src/any/date.rs Outdated Show resolved Hide resolved
@robertbastian robertbastian merged commit 6b98f3b into unicode-org:main Aug 25, 2022
@pdogr pdogr deleted the ctl branch August 25, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants