-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly/cronjob CI #2718
Comments
Another way to configure it would be a webhook that gets triggered on a periodic basis or whenever there's a new Rust Nightly. There are lots of ways we can set up a webhook. |
Hitting sagiegurari/cargo-make#722 when I try to do an override situation |
Actually why nightly? Seems like we should be testing on beta, which prepares us for the next stable release, but isn't as unstable as nightly. |
@robertbastian immediate notification of breakages so we have time to report stuff upstream and get it fixed if we need without asking for uplifts. |
I want to be using the most unstable thing here. Also people will use icu4x from nightly and I want it to work as much as possible. It should, nightly is reasonably stable now, but there are still occasional moments especially since we do some weird stuff. |
Just as a data point, 39 out of 78 nightly CI runs have failed. Given those numbers the bot might be a bit spammy. |
@robertbastian well, most of that was before we had the notifier, so we had a breakage stay broken for quite a while. We've only had two total breakages in those 78 runs, just that one was out of our hands to fix and we had to wait a while, and the other went unnoticed for a while. 2 out of 78 isn't bad. I'm also fine with the bot being that spammy, I want to fix things when they break. The cost is just a message in Slack. Basically we have two kinds of breakages: ones we can fix and ones we can't. For the ones we can fix hopefully they get fixed before the next time the bot complains (but otherwise they'll be fixed at most a couple complaints later), it's really the other ones that are the problem but rustc tends to take less than a week to fix those and I'm fine with that. |
While we shouldn't run every PR on this, we should set up a "nightly" CI that:
make full-data
, or running clippy with the pinned nightly, or whatever.I think the way to do this would be to:
on.schedule.cron = "/7 * * * * "
or whatever in build-test.ymlbuild-test.yml
starts off with a step that:on.schedule.cron
variable, and if true:rustup override nightly
full-data
(and other stuff?)The text was updated successfully, but these errors were encountered: