New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly cronjob CI #2836

Merged

Manishearth merged 11 commits into unicode-org:main from Manishearth:cronjob

Nov 22, 2022

Member

Manishearth commented Nov 21, 2022 •

edited

Loading

Fixes #2718

This is reviewable now, but please do not merge yet, since for the purposes of testing I've made it so that the nightly CI is run for the pull_request task as well.

This adds a cronjob (and a manually-triggerable) CI task that runs everything¹ under the latest nightly. It does this by conditionally setting env vars, so future changes to CI will automatically inherit this as long as new jobs use the same boilerplate. There are also env vars that allow us to skip or fixup tests that are testing things on specific compiler versions.

Except for the clippy build and the rustdoc-json using stuff ↩

Manishearth force-pushed the cronjob branch from b97023e to f27f71b Compare

November 21, 2022 19:22

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from f27f71b to e552899 Compare

November 21, 2022 19:23

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from e552899 to a4d561c Compare

November 21, 2022 19:23

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from a4d561c to 64c6791 Compare

November 21, 2022 19:24

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 64c6791 to 64ea30a Compare

November 21, 2022 19:25

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 64ea30a to 4b82537 Compare

November 21, 2022 19:29

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 4b82537 to 6e4001c Compare

November 21, 2022 19:31

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 6e4001c to f3c9d28 Compare

November 21, 2022 19:40

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from f3c9d28 to bc28909 Compare

November 21, 2022 19:43

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot


          Uniform indentation

b2e23de

Manishearth force-pushed the cronjob branch from bc28909 to 4e190fc Compare

November 21, 2022 20:01

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot


          wip nightly cronjob CI

a46f07b

Manishearth force-pushed the cronjob branch from 4e190fc to a46f07b Compare

November 21, 2022 20:04

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot


          Fix GN task on nightly

ec6e7f3

Manishearth force-pushed the cronjob branch from 263d68a to e5d7f38 Compare

November 21, 2022 20:35

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different
Makefile.toml is now changed in the branch
tools/scripts/ffi.toml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from e5d7f38 to c1a6678 Compare

November 21, 2022 20:39

jira-pull-request-webhook bot commented Nov 21, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from c1a6678 to ff076a0 Compare

November 21, 2022 20:43

Manishearth force-pushed the cronjob branch from e604299 to ea7a12f Compare

November 22, 2022 03:32

echeran reviewed

View reviewed changes

Makefile.toml Outdated

Comment on lines 189 to 200

+              echo ${env_file}
+              needs_run = exec cargo make --loglevel error check-needs-force-nightly-ci
+              echo ${needs_run}
+              if eq "${needs_run}" "yes"
+                  echo "Setting up CI environment for forced-nightly Rust build"
+                  appendfile ${env_file} "ICU4X_NIGHTLY_TOOLCHAIN=nightly\n"
+                  appendfile ${env_file} "INSTALLED_NIGHTLY_VERSION=nightly\n"
+                  appendfile ${env_file} "ICU4X_BUILDING_WITH_FORCED_NIGHTLY=1\n"
+                  appendfile ${env_file} "RUSTDOCFLAGS=--cfg ICU4X_BUILDING_WITH_FORCED_NIGHTLY\n"
+                  exec rustup override set nightly
+              else
+                  echo "forced-nightly environment not required"
+              end

Contributor

echeran Nov 22, 2022

question: does this file whose path is in GITHUB_ENV persist across the workflow?

I wonder if we can run the boilerplate step in one job in order to initialize the values across jobs. Then have all other jobs depend on the initialization job.

Member Author

Manishearth Nov 22, 2022

I don't think so.

You should experiment with this later, I don't want to spend too much time cleaning this up. This is far from the only instance of boilerplate we have.

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

Makefile.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from ea7a12f to 00d329e Compare

November 22, 2022 03:41

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 00d329e to d185a89 Compare

November 22, 2022 03:47

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from d185a89 to 3d2d04d Compare

November 22, 2022 03:48

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

Makefile.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Manishearth force-pushed the cronjob branch from 3d2d04d to 0341170 Compare

November 22, 2022 03:51

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot


          Move to makefile

9997d21

Member Author

Manishearth commented Nov 22, 2022

@echeran I think it's ready for review again

To land, I need to disable the wearos task on nightly, or alternatively wait a couple days for the cortex fix to land upstream, and then I need to remove pull_request from the conditions.

Member Author

Manishearth commented Nov 22, 2022

Once this lands I also want to set up a notification for build failures so I can keep it working

echeran previously approved these changes

View reviewed changes

Contributor

echeran left a comment

LGTM after a valiant slog through CI. Looking forward to seeing it in action. I'll let you carefully decide when the right time to try to merge this should be.


          remove PR gating

eb5c0c8

Manishearth dismissed echeran’s stale review via

eb5c0c8

November 22, 2022 17:09

Manishearth force-pushed the cronjob branch from 0341170 to eb5c0c8 Compare

November 22, 2022 17:09

jira-pull-request-webhook bot commented Nov 22, 2022

Notice: the branch changed across the force-push!

.github/workflows/build-test.yml is different
Makefile.toml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Member Author

Manishearth commented Nov 22, 2022

I decided to let this CI be failing for the first few rounds. The upstream Rust fix has already landed, so it'll be in by the next nightly.

I haven't yet hooked up notifications or anything so it doesn't matter.


          fix memory

07f033e

Manishearth marked this pull request as ready for review

November 22, 2022 17:20

Manishearth requested review from sffc, zbraniecki, nciric and a team as code owners

November 22, 2022 17:20

echeran approved these changes

View reviewed changes

Manishearth merged commit f23e4f9 into unicode-org:main

Manishearth deleted the cronjob branch

November 22, 2022 18:23

sffc removed their request for review

December 5, 2022 11:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet