Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time zone datagen: Don't assume timeZoneNames.json is self-describing #4044

Open
sffc opened this issue Sep 14, 2023 · 2 comments
Open

Time zone datagen: Don't assume timeZoneNames.json is self-describing #4044

sffc opened this issue Sep 14, 2023 · 2 comments
Assignees
@sffc
Labels
C-time-zone Component: Time Zones
Milestone
Priority Backlog ...

Comments

@sffc
Copy link
Member

sffc commented Sep 14, 2023

Datagen should be upgraded to support the new iana attribute when generating data for the IanaToBcp47Mapper (#2909).

See https://unicode-org.atlassian.net/browse/CLDR-14453
@sffc sffc added the C-time-zone Component: Time Zones label Sep 14, 2023
@sffc sffc mentioned this issue Sep 14, 2023
Merged
@sffc sffc added this to the 1.4 Blocking ⟨P1⟩ milestone Sep 14, 2023
@sffc sffc changed the title Adopt new iana attribute from CLDR 44 Adopt new iana attribute and improve time zone datagen in CLDR 44 Oct 16, 2023
@sffc
Copy link
Member Author

sffc commented Oct 16, 2023

Another item to investigate here from @srl295

Wait a second, though, this is trying to make the localization file self-describing. The _alias field of cldr-bcp47/bcp47/timezone.json already has an exhaustive enumeration of all valid tzids. Can't you just use that to define the shape?

  • America/Asuncion
  • America/Indiana/Vincennes
    …

So after we fix up how we consume timezone.json, we should use this to also fix up how we consume timeZoneNames.json

@sffc sffc mentioned this issue Oct 16, 2023
Merged
@sffc sffc self-assigned this Oct 16, 2023
@sffc sffc mentioned this issue Oct 25, 2023
Merged
sffc added a commit that referenced this issue Oct 27, 2023
@sffc
Datagen: Consume iana field in timezone.json (#4218)
2f1a6c1 
First part of #4044

The data changed because we're selecting a different value from the
aliases list than we were before. However, upon upgrading to CLDR 44,
this is a well defined algorithm.
@sffc
Copy link
Member Author

sffc commented Nov 14, 2023

We are correctly consuming the iana attribute, but I haven't yet done the change described in #4044 (comment). I will move this issue to a later milestone.

@sffc sffc changed the title Adopt new iana attribute and improve time zone datagen in CLDR 44 Time zone datagen: Don't assume timeZoneNames.json is self-describing Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-time-zone Component: Time Zones
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

No branches or pull requests
1 participant
@sffc