Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICU 74 property enums #4132

Closed
sffc opened this issue Oct 6, 2023 · 0 comments · Fixed by #4282
Closed

Add ICU 74 property enums #4132

sffc opened this issue Oct 6, 2023 · 0 comments · Fixed by #4282
Assignees
Labels
A-data Area: Data coverage or quality C-unicode Component: Props, sets, tries

Comments

@sffc
Copy link
Member

sffc commented Oct 6, 2023

Markus added these property values to ICU4C 74 code. We may need to do the same in ICU4X:

C/C++

unicode/uchar.h

enum UBlockCode {
    // New block in Unicode 15.1

    /** @stable ICU 74 */
    UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I = 328, /*[2EBF0]*/

typedef enum ULineBreak {
    /** @stable ICU 74 */
    U_LB_AKSARA = 43,            /*[AK]*/
    /** @stable ICU 74 */
    U_LB_AKSARA_PREBASE = 44,    /*[AP]*/
    /** @stable ICU 74 */
    U_LB_AKSARA_START = 45,      /*[AS]*/
    /** @stable ICU 74 */
    U_LB_VIRAMA_FINAL = 46,      /*[VF]*/
    /** @stable ICU 74 */
    U_LB_VIRAMA = 47,            /*[VI]*/


Java

public final class UCharacter {
    public static final class UnicodeBlock extends Character.Subset {
        // New block in Unicode 15.1

        /** @stable ICU 74 */
        public static final int CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I_ID = 328; /*[2EBF0]*/

        ...

        // New block in Unicode 15.1

        /** @stable ICU 74 */
        public static final UnicodeBlock CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I =
                new UnicodeBlock("CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I",
                        CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I_ID); /*[2EBF0]*/

    public static interface LineBreak
    {
        /** @stable ICU 74 */
        public static final int AKSARA = 43;  /*[AK]*/ /* from here on: new in Unicode 15.1/ICU 74 */
        /** @stable ICU 74 */
        public static final int AKSARA_PREBASE = 44;  /*[AP]*/
        /** @stable ICU 74 */
        public static final int AKSARA_START = 45;  /*[AS]*/
        /** @stable ICU 74 */
        public static final int VIRAMA_FINAL = 46;  /*[VF]*/
        /** @stable ICU 74 */
        public static final int VIRAMA = 47;  /*[VI]*/

public final class VersionInfo {
    /**
     * Unicode 15.1 version
     * @stable ICU 74
     */
    public static final VersionInfo UNICODE_15_1;

As a bonus, add a test to make sure these stay in sync.

@sffc sffc added C-unicode Component: Props, sets, tries A-data Area: Data coverage or quality labels Oct 6, 2023
@sffc sffc added this to the 1.4 Blocking ⟨P1⟩ milestone Oct 6, 2023
@sffc sffc assigned sffc and unassigned echeran Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-data Area: Data coverage or quality C-unicode Component: Props, sets, tries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants