-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolution between API options and -u- Locale extensions (migrate constructors to ICU4X Preferences) #419
Comments
@mihnita - Every formatter should look at @zbraniecki - There should be a common resolution logic helper. @nciric - We largely deal with this in ECMA-402. |
Deliverable: make the shared helper class. A utility. Document in the style guide. |
Revisit in 0.3 |
@sffc to draft a design doc. |
See #2136 for additional discussion. For ICU4X 1.0 we agreed to move forward with option 3 above, but we will definitely continue to consider adopting Preferences in ICU4X 2.0 |
Is that |
it is |
Notes about icu_preferences integration plan:
|
Plan:
|
I've tried to migrate
|
My proposal would be:
|
Another issue: resolving preferences requires data. Where does this data come from? |
I feel like ResolvedPreferences is trying to do multiple things at once:
But, these are two separate operations. Only the second one needs data, and the first one needs to keep track of extra things like |
Everyone is on Preferences now, this should be done. |
ICU4C and ICU4J are inconsistent in honoring
-u-
extensions. Sometimes the formatters obey them, or not. They also support setters instead of-u-
. Can we do something in ICU4X to unify the pattern around the resolution between-u-
and API options?The text was updated successfully, but these errors were encountered: