Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-dynamic version of DataProvider #422

Closed
sffc opened this issue Dec 17, 2020 · 0 comments · Fixed by #431
Closed

Add non-dynamic version of DataProvider #422

sffc opened this issue Dec 17, 2020 · 0 comments · Fixed by #431
Assignees
@sffc
Labels
C-data-infra Component: provider, datagen, fallback, adapters T-enhancement Type: Nice-to-have but not required

Comments

@sffc
Copy link
Member

sffc commented Dec 17, 2020

DataProvider currently passes all data through dynamic dispatch and type downcasting, in order to support being used as a trait object. As an alternative for users, we should add a version that uses generics. We can have DataProvider and DataProviderCore, like Rnd and RndCore in the rnd crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-data-infra Component: provider, datagen, fallback, adapters T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming and refactoring DataKey, DataEntry, and other traits; adding ErasedDataProvider sffc/omnicu
1 participant
@sffc