Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using DataProvider<ErasedDataStruct> instead of ErasedDataProvider #434

Closed
sffc opened this issue Dec 31, 2020 · 1 comment
Closed

Consider using DataProvider<ErasedDataStruct> instead of ErasedDataProvider #434

sffc opened this issue Dec 31, 2020 · 1 comment
Assignees
@sffc
Labels
A-design Area: Architecture or design C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality

Comments

@sffc
Copy link
Member

sffc commented Dec 31, 2020

I realized through the course of working on #422 and #431 that it may be possible to take what I currently have proposed as ErasedDataProvider and instead make it simply a generic DataProvider with the type parameter set to ErasedDataStruct: DataProvider<ErasedDataStruct>.

Putting on the backlog for now, because I want to move on to other tasks.
@sffc sffc added backlog T-core Type: Required functionality C-data-infra Component: provider, datagen, fallback, adapters A-design Area: Architecture or design labels Dec 31, 2020
@sffc sffc self-assigned this Dec 31, 2020
@sffc sffc added the S-small Size: One afternoon (small bug fix or enhancement) label Apr 3, 2021
@sffc
Copy link
Member Author

sffc commented Feb 1, 2022

This is obsolete. We now have AnyProvider and AnyMarker.

@sffc sffc closed this as completed Feb 1, 2022
@sffc sffc added R-obsolete Resolution: This issue is no longer relevant and removed v1 labels Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
A-design Area: Architecture or design C-data-infra Component: provider, datagen, fallback, adapters R-obsolete Resolution: This issue is no longer relevant S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sffc