Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary enumerated properties data provider; update uprop toml files #1047

Merged
merged 6 commits into from
Sep 14, 2021
Merged

Add binary enumerated properties data provider; update uprop toml files #1047

merged 6 commits into from
Sep 14, 2021

Conversation

iainireland
Copy link
Contributor

Fixes #883.

@iainireland iainireland self-assigned this Sep 13, 2021
@iainireland iainireland requested a review from a team as a code owner September 13, 2021 19:33
zbraniecki
zbraniecki previously approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good!

Just for my mental model - why do we use toml here while we use json everywhere else?

provider/uprops/src/upropdump_serde.rs Outdated Show resolved Hide resolved
sffc
sffc requested changes Sep 13, 2021
View reviewed changes
provider/testdata/data/uprops/sc.toml Outdated Show resolved Hide resolved
provider/uprops/src/enumerated.rs Show resolved Hide resolved
provider/uprops/src/upropdump_serde.rs Outdated Show resolved Hide resolved
@sffc
Copy link
Member

sffc commented Sep 13, 2021

the code looks good!

Just for my mental model - why do we use toml here while we use json everywhere else?

Because the Unicode property data coming from ICU is in TOML, whereas the locale data coming from CLDR is in JSON.

zbraniecki
zbraniecki previously approved these changes Sep 13, 2021
View reviewed changes
provider/uprops/src/enumerated.rs Outdated Show resolved Hide resolved
@iainireland iainireland requested a review from sffc September 14, 2021 00:00
sffc
sffc approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please make sure your commit message mentions why there is a diff in the toml files.

@sffc sffc changed the title Enumerated props Add binary enumerated properties data provider; update uprop toml files Sep 14, 2021
@iainireland iainireland merged commit d5a9f48 into unicode-org:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@zbraniecki zbraniecki zbraniecki left review comments

Assignees

@iainireland iainireland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import ICU4C enumerated properties data into ICU4X
3 participants
@iainireland @sffc @zbraniecki