Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade default rust-toolchain to 1.56-beta.3 #1085

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 22, 2021

This unblocks various PRs that need to use .map_project() and related functions (such as #1084). It also unblocks us to start updating the Yoke and DataPayload APIs to turn on examples and remove obsolete functions like with_context (#1061).

We will switch to 1.56 stable on October 21, and we will not push anything to crates.io unless the code builds on stable.

@sffc sffc requested a review from a team as a code owner September 22, 2021 20:21
zbraniecki
zbraniecki previously approved these changes Sep 22, 2021
@sffc
Copy link
Member Author

sffc commented Sep 22, 2021

Hmm

---- src/trait_hack.rs - trait_hack (line 31) stdout ----
Test compiled successfully, but it's marked `compile_fail`.

failures:
    src/trait_hack.rs - trait_hack (line 31)

test result: FAILED. 25 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 3.15s

I'll fix it.

@sffc
Copy link
Member Author

sffc commented Sep 22, 2021

OK, CI is happy. Need another approval.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also unmark the other yoke examples as compile_fail? And perhaps file a followup to get rid of the trait hack

@sffc
Copy link
Member Author

sffc commented Sep 22, 2021

I'll follow up with another PR shortly to address #1061 and get the Yoke/DataPayload examples in order.

@sffc sffc merged commit a342c02 into unicode-org:main Sep 22, 2021
@sffc sffc deleted the rust-156 branch September 22, 2021 22:09
@sffc
Copy link
Member Author

sffc commented Sep 22, 2021

(merging based on Zibi's previous approval)

@Manishearth
Copy link
Member

wfm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants