Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UleError type; use for PlainOldULE and char conversions #1147

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Add UleError type; use for PlainOldULE and char conversions #1147

merged 3 commits into from
Oct 4, 2021

Conversation

Manishearth
Copy link
Member

Fixes #1144

@Manishearth Manishearth requested a review from sffc as a code owner October 4, 2021 16:54
@zbraniecki zbraniecki requested review from zbraniecki and removed request for sffc October 4, 2021 18:38
zbraniecki
zbraniecki previously approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Manishearth Manishearth requested a review from zbraniecki October 4, 2021 19:48
@Manishearth Manishearth merged commit e658201 into unicode-org:main Oct 4, 2021
@Manishearth Manishearth deleted the uleerror branch October 4, 2021 20:29
@Manishearth Manishearth restored the uleerror branch October 4, 2021 20:29
@Manishearth Manishearth deleted the uleerror branch October 4, 2021 20:29
@Manishearth Manishearth restored the uleerror branch October 4, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail with length error in PlainOldULE, CharULE, etc.
2 participants
@Manishearth @zbraniecki