Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic impl of EncodeAsVarULE #1173

Merged
merged 11 commits into from
Oct 20, 2021
Merged

Basic impl of EncodeAsVarULE #1173

merged 11 commits into from
Oct 20, 2021

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 15, 2021 •
edited
Loading

Part of #1082

cc @zbraniecki here you go

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/zerovec/src/varzerovec/components.rs is different
  • utils/zerovec/src/varzerovec/encode.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth Manishearth mentioned this pull request Oct 15, 2021
Closed
29 tasks
@Manishearth
Copy link
Member Author

Manishearth commented Oct 15, 2021 •
edited
Loading

There is no polish yet but feel free to review the actual code.

sffc
sffc reviewed Oct 15, 2021
View reviewed changes
utils/zerovec/src/varzerovec/components.rs Show resolved Hide resolved
utils/zerovec/src/varzerovec/encode.rs Outdated Show resolved Hide resolved
utils/zerovec/src/varzerovec/encode.rs Outdated Show resolved Hide resolved
@sffc sffc mentioned this pull request Oct 16, 2021
Closed
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • utils/zerovec/src/varzerovec/components.rs is different
  • utils/zerovec/src/varzerovec/encode.rs is different
  • utils/zerovec/src/varzerovec/mod.rs is different
  • utils/zerovec/src/varzerovec/owned.rs is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@Manishearth
Copy link
Member Author

Updated with a doctest and rebased. Todo: add safety docs

@Manishearth Manishearth requested a review from sffc October 19, 2021 17:54
@Manishearth Manishearth marked this pull request as ready for review October 19, 2021 17:54
@Manishearth
Copy link
Member Author

I decided to move this to a new ule::custom module since we'll probably also have FromVarULE or whatever there too, and this gives us a single place for docs for custom VarULEs.

sffc
sffc requested changes Oct 19, 2021
View reviewed changes
utils/zerovec/src/ule/custom/mod.rs Show resolved Hide resolved
utils/zerovec/src/varzerovec/components.rs Outdated Show resolved Hide resolved
utils/zerovec/src/varzerovec/owned.rs Show resolved Hide resolved
@Manishearth @sffc
Update utils/zerovec/src/varzerovec/components.rs
b8fa1d6 
Co-authored-by: Shane F. Carr <shane@unicode.org>
@Manishearth Manishearth requested a review from sffc October 19, 2021 18:44
@Manishearth Manishearth mentioned this pull request Oct 19, 2021
Closed
@Manishearth Manishearth added this to the 2021 Q4 0.5 Sprint A milestone Oct 19, 2021
@sffc sffc removed this from the 2021 Q4 0.5 Sprint A milestone Oct 20, 2021
@sffc sffc added this to the ICU4X 0.4 milestone Oct 20, 2021
@Manishearth Manishearth merged commit 82ea03a into unicode-org:main Oct 20, 2021
@Manishearth Manishearth deleted the encode-var-ule branch October 20, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ICU4X 0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc