Add more methods to EncodeAsVarULE #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2021
Closed
sffc
requested changes
Oct 22, 2021
Comment on lines
65
to
66
| /// Write the corresponding [`VarULE`] type to the `dst` buffer. `dst` should | ||
| /// be the size of [`Self::encoded_var_ule_length()`] |
There was a problem hiding this comment.
Is the "should" here a safety constraint?
Do the bytes need to be initialized? If not, should we require that the impl writes across every byte?
There was a problem hiding this comment.
Right now it's written such that implementations will panic if it's not followed, hence the should not must.
&mut [u8] in rust is invalid if not initialized: if we wish to allow uninitialized buffers, we must use *mut [u8] instead.
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1082
fixes #1179
Names bikesheddable, I wanted them to all mention
var_uleat least.