Remove RcStruct #1299
Merged
Remove RcStruct #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
im-not-owned
branch
from
994bd2c to
bb0bb93
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
2 tasks
sffc
approved these changes
Nov 15, 2021
| /// `dyn Drop` isn't legal (and doesn't make sense since `Drop` is not | ||
| /// implement on all destructible types). However, all trait objects come with | ||
| /// a destructor, so we can just use an empty trait to get a destructor object. | ||
| pub trait ErasedDestructor: 'static {} |
There was a problem hiding this comment.
Thought: We're not actually using this in DataPayload, right? Because we are instead just Boxing the whole Yoke into a trait object? So we may or may not need this; if it doesn't solve our use case, is it going to solve anyone else's?
There was a problem hiding this comment.
Yes, I think that this is generally useful, it's just not useful for us anymore.
It may actually become useful in the future if we ever add e.g. RcRef or something.
There was a problem hiding this comment.
We also can probably clean up the "Box the entire yoke into a trait object" business if we try, actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(finally)
Fixes #1262, fixes #1284
#1297 had all the churny parts of this change so this PR should be much more manageable (and can be reviewed at leisure).
This contains a bunch of related changes:
DataPayload::new_owned()fromDataPayload::from_partial_owned()ErasedCartintoyoke(Add Yoke::erase_cart() to Yoke #1284) and adding nice helper methods for working with it. We don't use it anymore, but it does seem generally useful.DataPayloadInner::RcStructandDataPayload::from_partial_owned()It should be easy to re-add an
ErasedCartbasedRcRef(Yoke<&'static Y, ErasedRcCart>)later if needed. It's worth waiting to see what our needs are in this area before adding new variants or constructors;Yokeis pretty versatile so we should be able to use it as needed.