Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fxhash_32 #1504

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Add fxhash_32 #1504

merged 2 commits into from
Jan 18, 2022

Conversation

sffc
Copy link
Member

@sffc sffc commented Jan 13, 2022

Utility function prerequisite for #1148

@sffc sffc marked this pull request as ready for review January 13, 2022 21:41
@sffc
Copy link
Member Author

sffc commented Jan 13, 2022

@Manishearth @hsivonen @alolita PTAL at the boilerplate I added and verify that I am attributing the code correctly.

Manishearth
Manishearth previously approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good from my end 👍

might be worth asking rustc_hash to make their code const

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member Author

sffc commented Jan 14, 2022

^ this is a squash.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member Author

sffc commented Jan 14, 2022

^ this is a rebase.

Manishearth
Manishearth previously approved these changes Jan 14, 2022
View reviewed changes
@sffc
Feedback
f00856c 
Clippy

Add boilerplate

Add fxhash_32
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc
Copy link
Member Author

sffc commented Jan 15, 2022

^ rebase again.

Waiting for approval from @hsivonen or @alolita

@sffc sffc mentioned this pull request Jan 17, 2022
Merged
@sffc sffc requested a review from robertbastian January 18, 2022 18:17
@sffc
Copy link
Member Author

sffc commented Jan 18, 2022

In order to get unblocked, I am going to merge this PR. I am still going to be on the lookout for a review from @alolita and make a follow-up PR with any necessary changes.

@sffc sffc merged commit 55f95e1 into unicode-org:main Jan 18, 2022
@sffc sffc deleted the fxhash branch January 18, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@Manishearth Manishearth Manishearth approved these changes

@hsivonen hsivonen Awaiting requested review from hsivonen

@alolita alolita Awaiting requested review from alolita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @Manishearth @robertbastian