Add design doc for zerovec #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
reviewed
Jan 28, 2022
utils/zerovec/design_doc.md
Outdated
|
|
||
| These can only be applied to structs where all fields are ULE types (for `#[derive(VarULE)]`, the last field must be an unsized `VarULE` type). These derives will do the following things: | ||
|
|
||
| - Apply `#[repr(packed)]` to the type |
There was a problem hiding this comment.
If all fields are ULE then it doesn't need #[repr(packed)], right?
There was a problem hiding this comment.
No, it still needs it, repr(Rust) is not stable or defined
There was a problem hiding this comment.
Does repr(C) produce the same result as repr(packed) on types with ULE fields?
There was a problem hiding this comment.
I'm not sure.... maybe? It's worth looking in to. It would certainly make some things easier since rust has restrictions on packed types.
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
previously approved these changes
Jan 28, 2022
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #1475
I haven't done a final pass but I think this is ready for review to at least start.