Make Region, Script, and Variant subtags ULE #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
Manishearth
and removed request for
zbraniecki and
nciric
Manishearth
requested changes
Mar 15, 2022
| @@ -38,6 +38,7 @@ tinystr = { path = "../../utils/tinystr", version = "0.5.0", features = ["alloc" | |||
| serde = { version = "1.0", optional = true, default-features = false, features = ["alloc"] } | |||
| writeable = { version = "0.3", path = "../../utils/writeable" } | |||
| displaydoc = { version = "0.2.3", default-features = false } | |||
| zerovec = { version = "0.6", path = "../../utils/zerovec", optional = true } | |||
There was a problem hiding this comment.
thought: hmm, this is the first time we're making zerovec optional. I see why — locid doesn't need it, locid's clients do. I feel like given the generally pervasive use of zerovec I'd be open to making this a mandatory dependency, but either works for me.
There was a problem hiding this comment.
Let's discuss in a separate issue: #1700
|
🎉 All dependencies have been resolved ! |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
^ These are both rebases; no code changes. |
|
Ready for re-review. The code changes are the last two commits. |
Manishearth
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #831
Depends on #1694
This PR is intended to be non-controversial. I split
Languageinto its own PR #1695 since that one is not already its own ULE.Note: This PR is intended to be based on top of #1694.