-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put date skeletons behind a feature #2370
Conversation
Activate this feature in https://github.com/unicode-org/icu4x/blob/main/components/icu/Cargo.toml#L73 |
A thorny side-issue is that this brings up questions about whether or not "datagen" is stable for clients to use. We've gone back and forth on that topic before. |
)) | ||
} | ||
|
||
// No docs because the "experimental" version is what docs use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: worth noting the optional SkeletonsPattern bound in the docs of the other one ("The X bound is only needed with the experimental feature and enables blah blah")
As a side-effect, note how |
@zbraniecki The bench build is failing because the benches currently require components bag. If I do like I did in the tests where I skip over the components tests when the feature is not enabled, then the benches are going to have different results depending on what features are enabled, since enabling the experimental feature makes the benches run more examples. I could:
|
I think there are two issues remaining before CI is green:
|
I resolved the two issues above by:
|
Yippee! Merged. |
That's what I would suggest. All good! |
Fixes #2324
I added two features to icu_datetime: