Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Option<TinyAsciiStr> to be same size as TinyAsciiStr #2430

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Make Option<TinyAsciiStr> to be same size as TinyAsciiStr #2430

merged 5 commits into from
Aug 23, 2022

Conversation

pdogr
Copy link
Contributor

@pdogr pdogr commented Aug 22, 2022

Fixes #2083

@pdogr
- Introduce AsciiByte enum
78fd36e 
 - Change `TinyAsciiStr` to store array of `AsciiByte` instead of u8
@pdogr pdogr requested review from sffc and robertbastian August 22, 2022 09:49
@pdogr pdogr marked this pull request as ready for review August 22, 2022 09:49
@pdogr pdogr requested a review from a team as a code owner August 22, 2022 09:49
robertbastian
robertbastian reviewed Aug 22, 2022
View reviewed changes
utils/tinystr/src/ascii.rs Outdated Show resolved Hide resolved
utils/tinystr/src/ascii.rs Show resolved Hide resolved
@pdogr
Add safety comment for to unsafe blocks
1c6ea24 
Rename from_asciibytes to from_ascii_bytes
robertbastian
robertbastian previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but let's wait for @sffc's review as well

sffc
sffc previously approved these changes Aug 22, 2022
View reviewed changes
utils/tinystr/src/ascii.rs Outdated Show resolved Hide resolved
@pdogr pdogr dismissed stale reviews from sffc and robertbastian via 340fbb2 August 22, 2022 17:11
sffc
sffc reviewed Aug 22, 2022
View reviewed changes
utils/tinystr/src/asciibyte.rs Outdated Show resolved Hide resolved
utils/tinystr/src/asciibyte.rs Outdated Show resolved Hide resolved
@robertbastian robertbastian merged commit 59b1725 into unicode-org:main Aug 23, 2022
@pdogr pdogr deleted the tinystr branch August 23, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@robertbastian robertbastian robertbastian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Option<TinyAsciiStr> be the same size as TinyAsciiStr
3 participants
@pdogr @sffc @robertbastian