Fix Segmenter's missing FFI #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `icu_segmenter` to `icu::segmenter` in segmenter_grapheme.rs. This removes `segment_latin`, `segment_str`, and `segment_utf16` from the missing_apis.txt. Add all the types and types aliases that need no FFI to the IGNORED_PATHS.
|
You'll also need to run diplomat-gen since the doc links will change. If you wish I can include these changes in #2534 since I'm already touching that code |
Ah, thanks for the reminder! I would like to make this PR complete without breaking any CI. |
Manishearth
approved these changes
Sep 8, 2022
kelebra
pushed a commit
to kelebra/icu4x
that referenced
this pull request
Sep 9, 2022
* Fix Segmenter's missing FFI Change `icu_segmenter` to `icu::segmenter` in segmenter_grapheme.rs. This removes `segment_latin`, `segment_str`, and `segment_utf16` from the missing_apis.txt. Add all the types and types aliases that need no FFI to the IGNORED_PATHS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
icu_segmentertoicu::segmenterin segmenter_grapheme.rs. This removessegment_latin,segment_str, andsegment_utf16from the missing_apis.txt.Add all the types and types aliases that need no FFI to the IGNORED_PATHS.