Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databake improvements #2906

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Databake improvements #2906

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
079e702
improvements
robertbastian Dec 20, 2022
29a79bf
fix
robertbastian Dec 20, 2022
13b7a01
fix
robertbastian Dec 20, 2022
6843942
comments
robertbastian Dec 21, 2022
d5eb079
fix
robertbastian Dec 21, 2022
a805b7f
doc
robertbastian Dec 21, 2022
37f2334
non-breaking
robertbastian Dec 21, 2022
af3d99a
Merge branch 'main' into bake
robertbastian Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ ffi/diplomat/cpp/include/** linguist-generated=true
ffi/diplomat/cpp/docs/** linguist-generated=true
ffi/diplomat/js/include//** linguist-generated=true
ffi/diplomat/js/docs/** linguist-generated=true
*.rs.data linguist-language=Rust
robertbastian marked this conversation as resolved.
Show resolved Hide resolved
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/tutorials/data_management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ You can also make the `BakedDataProvider` implement the `AnyProvider` trait, so

```rust,compile_fail
include!("../my-data-mod/mod.rs");
include!("../my-data-mod/any.rs");
implement_any_provider!(BakedDataProvider);
robertbastian marked this conversation as resolved.
Show resolved Hide resolved
let _any_provider = BakedDataProvider;
```

Expand Down
1 change: 1 addition & 0 deletions provider/datagen/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ zip = "0.6"
cached-path = "0.5"
reqwest = { version = "0.11", features = ["blocking"] }
lazy_static = "1"
rust-format = { version = "0.3.4", features = ["token_stream"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: It's much better to do this at codegen time; I thought there was a reason we hadn't been doing that before? Is this a new crate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been calling rustfmt directly. This crate is just a nicer interface and also supports prettyplease, but that doesn't look good.


# Dependencies for "bin" feature
clap = { version = "2.33", optional = true }
Expand Down
Loading