Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR 43 Beta 3 #3185

Merged
merged 13 commits into from
Mar 30, 2023
Merged

CLDR 43 Beta 3 #3185

merged 13 commits into from
Mar 30, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Mar 9, 2023

@robertbastian

This comment was marked as outdated.

@robertbastian robertbastian changed the title CLDR 43 Alpha 2 CLDR 43 Beta 2 Mar 21, 2023
@robertbastian robertbastian marked this pull request as ready for review March 21, 2023 15:55
@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners March 21, 2023 15:55
Manishearth
Manishearth previously approved these changes Mar 21, 2023
@robertbastian robertbastian changed the title CLDR 43 Beta 2 CLDR 43 Beta 3 Mar 23, 2023
sffc
sffc previously approved these changes Mar 24, 2023
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Thank you very much for keeping code changes and data changes in their own separate PRs

@@ -1,18 +1,59 @@
{
"l2s": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought/Issue, not your fault: we should filter this list so that it doesn't grow so much on this update. I worked out a solution for the main likelysubtags but not this fallback side version. Actually I would like to deprecate this key entirely and we can do that now.

@robertbastian
Copy link
Member Author

Let's get this merged please

@sffc
Copy link
Member

sffc commented Mar 27, 2023

Please land #3225 first.

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@robertbastian robertbastian requested a review from sffc March 28, 2023 08:54
@@ -751,9 +750,8 @@ displaynames/regions@1, sr-Cyrl, 7715B, 51420e0d3503da27
displaynames/regions@1, sr-Latn, 4776B, e5961905fd208c83
displaynames/regions@1, th, 10811B, 84aad4d11372eb38
displaynames/regions@1, tr, 4650B, 8f8bd5f16f02a43
displaynames/regions@1, und, 2138B, 87850fe8d7efdd55
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What happened to displaynames/regions@1, und and also displaynames/languages@1, und

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

und only contained fallback mappings (DE -> DE), which are removed in 43.

@robertbastian robertbastian merged commit 5a2d203 into unicode-org:main Mar 30, 2023
@robertbastian robertbastian deleted the 43 branch March 30, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants