Switch datagen over to prettyplease #3363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datagen can't rely on rustfmt existing in the PATH. On the plus side, `prettyplease` has no qualms about formatting long lines (rustfmt bails), so some of our databake has gotten prettier. Also according to benchmarks on `prettyplease` it's faster (though it's not apples-to-apples) On the minus side, `prettyplease` doesn't group slice entries on the same line for large slices, so it can be a bit vertically sparse. I don't think this is too important. Ideally we can get a patch release with this so I can use it in Google3, however we may be able to just let this ride the trains until later.
Manishearth
requested review from
sffc,
robertbastian and
a team
as code owners
robertbastian
requested changes
Apr 20, 2023
| ) | ||
| .format_tokens(if is_expr { | ||
| // Rustfmt cannot format Rust expressions, only full files. We need to wrap expressions in a main function | ||
| let data = if is_expr { |
There was a problem hiding this comment.
I think prettyplease can work on arbitrary tokens.
There was a problem hiding this comment.
No, it needs a syn::File. I tried that, it panics.
| .ok_or_else(|| DataErrorKind::MissingLocale.with_req(::icu_timezone::provider::MetazonePeriodV1Marker::KEY, req)) | ||
| } | ||
| } | ||
| ($provider:path) => { |
There was a problem hiding this comment.
Yeah this is why we moved to rustfmt. I think it's a lot more important that this is readable than the .rs.data files.
There was a problem hiding this comment.
oh, yeah, i hadn't looked at this file. That's fair.
|
Discussion: we can eliminate the rust-format crate dependency by pulling the rustfmt call site into datagen itself. Then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datagen can't rely on rustfmt existing in the PATH.
On the plus side,
prettypleasehas no qualms about formatting long line (rustfmt bails), so some of our databake has gotten prettier. Also according to benchmarks onprettypleaseit's faster (though it's not apples-to-apples)On the minus side,
prettypleasedoesn't group slice entries on the same line for large slices, so it can be a bit vertically sparse. I don't think this is too important.Ideally we can get a patch release with this so I can use it in Google3, however we may be able to just let this ride the trains until later. Thoughts?