Using dictionaries from exportdata #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
exportdata
branch
from
ec96950
to
afdef40
Compare
This comment was marked as spam.
This comment was marked as spam.
robertbastian
force-pushed
the
exportdata
branch
from
afdef40
to
b0fbccc
Compare
This comment was marked as spam.
This comment was marked as spam.
robertbastian
force-pushed
the
exportdata
branch
from
b0fbccc
to
557d714
Compare
This comment was marked as spam.
This comment was marked as spam.
robertbastian
force-pushed
the
exportdata
branch
from
557d714
to
91b9650
Compare
This comment was marked as spam.
This comment was marked as spam.
robertbastian
force-pushed
the
exportdata
branch
from
91b9650
to
c4410c9
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
robertbastian
requested review from
Manishearth,
sffc,
aethanyc,
makotokato and
a team
as code owners
sffc
approved these changes
May 3, 2023
sffc
reviewed
May 3, 2023
Comment on lines
+142
to
+150
| std::fs::copy( | ||
| output_path | ||
| .join("icuexport/segmenter/dictionary") | ||
| .join(file), | ||
| output_path | ||
| .join("../../datagen/data/segmenter/dictionary") | ||
| .join(file), | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
Yes, good, the download script copies them here. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3395
The built-in segmentation files are based on ICU70, which is why there's a data diff now that the icuexport versions are found.
#3003