Use zeroslice! macros in ICU4X
#3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can use |
|
🎉 All dependencies have been resolved ! |
|
Depends on #3454 - specifically the decision made therein |
components/collections/src/codepointtrie/benches/tries/gc_fast.rs
Outdated
Show resolved
Hide resolved
This reverts commit 2397ad1.
skius
requested review from
Manishearth,
sffc,
hsivonen and
echeran
as code owners
Manishearth
approved these changes
Jun 2, 2023
robertbastian
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3453, part of #1935
This PR tries to use the
zeroslice!/zerovec!macros where possible in ICU4X. It also switches from user-provided array conversion functions to single-element conversion functions.