Add recommended locale set options and expand regions in datagen #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
pdogr,
snktd,
eggrobin,
zbraniecki,
gregtatum,
nordzilla,
hsivonen,
echeran and
a team
as code owners
robertbastian
removed request for
zbraniecki,
hsivonen,
echeran,
gregtatum,
eggrobin,
pdogr,
nordzilla and
snktd
sffc
requested changes
Jun 28, 2023
robertbastian
changed the title
robertbastian
requested review from
aethanyc,
makotokato and
dminor
as code owners
sffc
approved these changes
Jun 28, 2023
| return true; | ||
| } | ||
| let mut chain = fallbacker | ||
| .for_config(Default::default()) |
There was a problem hiding this comment.
Nit: The function should take the DataKey and you should use it when configuring the fallbacker
Manishearth
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3564
#3538
Fixes #3377