Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hebrew month codes into get_month_code_map #3841

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Move hebrew month codes into get_month_code_map #3841

merged 1 commit into from
Aug 10, 2023

Conversation

Manishearth
Copy link
Member

This is the cleanup I was suggesting: I'd prefer for the month codes to mostly live in the mapping function where possible.

@Manishearth
Copy link
Member Author

cc @sotam1069

sffc
sffc approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Not great that Hebrew logic is split between two functions but it's nice that we can use get_month_code_map again

@Manishearth Manishearth merged commit f516c9c into unicode-org:main Aug 10, 2023
@Manishearth Manishearth deleted the hebrew-map branch August 10, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@robertbastian robertbastian Awaiting requested review from robertbastian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @sffc