-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not requiring --use-separate-crates
for compiled data
#3847
Conversation
I'm not opposed to this change but I think I'm missing something about the motivation: "Replacing compiled data should not require extra icu4x-datagen flags". Can you share more details? We probably should document how to use this; personally I find the non metacrate solution to be more intuitive and less likely to make people try and create cyclic deps. |
The default datagen mode is using meta crate names, and I want compiled data to work with that. I think that's a reasonable default, because we tell our clients in all our tutorials to use the meta crate. This change makes individual crates like |
--use-separate crates
for compiled data--use-separate-crates
for compiled data
ah, right, forgot about that +1 |
Replacing compiled data should not require extra
icu4x-datagen
flags. This also aligns theconfig.json
more with the CLI arguments (it previously inverted the flag asuse_meta_crate
to get atrue
default).#2945
#3564