Datagen API review feedback #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Sep 18, 2023
| @@ -80,7 +80,7 @@ $ icu4x-datagen config.json | |||
|
|
|||
There was a problem hiding this comment.
Did you fix this one?
DatagenProvider: ExportableProvider link is broken
There was a problem hiding this comment.
Couldn't reproduce this
There was a problem hiding this comment.
It's on this page: https://unicode-org.github.io/icu4x/docs/icu_datagen/struct.DatagenProvider.html
The link to ExportableProvider is a 404.
There was a problem hiding this comment.
It doesn't reproduce locally, so shouldn't be an actual issue on crates.io.
Manishearth
approved these changes
Sep 19, 2023
sffc
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3564