Make auxiliary key code experimental #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
Sep 21, 2023
Comment on lines
+258
to
+262
| if aux_iter.next().is_some() { | ||
| return Err(DataErrorKind::KeyLocaleSyntax | ||
| .into_error() | ||
| .with_display_context(s)); | ||
| } |
There was a problem hiding this comment.
Note: This code here is a behavior change (not allowing unknown characters after parsing), but this FromStr impl is new in this release. I added a test for it.
Manishearth
previously approved these changes
Sep 21, 2023
robertbastian
previously approved these changes
Sep 21, 2023
robertbastian
dismissed stale reviews from Manishearth and themself
via
62c733d
robertbastian
approved these changes
Sep 21, 2023
sffc
commented
Sep 21, 2023
| @@ -58,7 +58,7 @@ icu_unitsconversion = { workspace = true, features = ["datagen"], optional = tru | |||
| icu_codepointtrie_builder = { workspace = true } | |||
| icu_collections = { workspace = true, features = ["serde"] } | |||
| icu_locid = { workspace = true, features = ["std", "serde"] } | |||
| icu_provider = { workspace = true, features = ["std", "logging", "datagen"]} | |||
| icu_provider = { workspace = true, features = ["std", "logging", "datagen", "experimental"]} | |||
There was a problem hiding this comment.
Okay, it's datagen. I didn't want the experimental feature globally enabled for library code but I guess it's fine here, especially since it gets transitively enabled from icu_transliterate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 1.3 blocking aspects of #3632
I added an experimental feature instead of simply using doc(hidden) because