Fix indexing bug in ZeroMap2d::insert #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Oct 16, 2023
sffc
changed the title
|
Found the bug and pushed a fix. |
sffc
commented
Oct 18, 2023
| + match self.keys1.zvl_binary_search_in_range(key1, range).unwrap() { | ||
| Ok(index) => return Some(self.values.zvl_replace(index, value)), | ||
| Ok(index) => return Some(self.values.zvl_replace(range_start + index, value)), |
There was a problem hiding this comment.
The bug is here; it was overwriting the wrong value in the map.
|
I don't think we need a patch release since this is not a regression in behavior, but I would not oppose a patch release. It appears |
Manishearth
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4161