Fix deduplication in datagen #4233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| - [Fix #4165, locale "vi" not working in Collator](https://github.com/unicode-org/icu4x/issues/4165): | ||
| - `icu_collator` | ||
| - `icu_collator_data` | ||
| - [Fix #4232, some locale data being improperly deduplicated](https://github.com/unicode-org/icu4x/issues/4232): |
There was a problem hiding this comment.
can we be more specific? what data exactly did this affect?
There was a problem hiding this comment.
People can click the bug link for more details
There was a problem hiding this comment.
not clear from the bug for me. It mentions es-MX, but the diff includes other languages as well
There was a problem hiding this comment.
I added a bit more info in the bug.
Manishearth
approved these changes
Oct 27, 2023
sffc
added a commit
that referenced
this pull request
Oct 27, 2023
sffc
added a commit
that referenced
this pull request
Oct 27, 2023
sffc
added a commit
that referenced
this pull request
Oct 27, 2023
sffc
added a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 03cba37)
sffc
added a commit
that referenced
this pull request
Oct 27, 2023
|
I merged this via command line in order to keep the commits separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4232
I want to put this on the 1.3 branch.
This was discovered by @sven-oly's conformance test suite.