Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Bake for BTreeSet #4268

Merged

Conversation

adamchalmers
Copy link
Contributor

This is my attempt to start #4266.

I am confused why the unit test I added is failing -- I might be missing something about how quote! works.

thread 'alloc::hash_set' panicked at utils/databake/src/alloc.rs:75:5:
assertion `left == right` failed
  left: "alloc :: collections :: BTreeSet :: from ([1u8 , 2u8 ,])"
 right: "alloc :: collections :: BTreeSet :: from ([1u8 , 2u8])"

IMO those two should be the same, but I'm not sure why the left has a trailing comma. I'd appreciate help from anyone who understands what's going on there!

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

@Manishearth
Copy link
Member

Pushed the test fix for you. The token tree testing stuff is a bit tricky around trailing commas.

Manishearth
Manishearth previously approved these changes Nov 9, 2023
@adamchalmers
Copy link
Contributor Author

Thanks very much Manish!

@Manishearth Manishearth merged commit c472292 into unicode-org:main Nov 9, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants