Bump Diplomat and use DiplomatChar
#4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
previously requested changes
Nov 22, 2023
| } | ||
|
|
||
| /// See [`Self::remove_char`] | ||
| pub fn remove_u32(&mut self, c: u32) { |
There was a problem hiding this comment.
Issue: these functions should be named foo32 if they take a u32 argument and foo_u32 if they return a u32. Previous discussion: #2413 (comment)
There was a problem hiding this comment.
There are existing foo_u32 methods here. Do we want to break consistency?
There was a problem hiding this comment.
Yeah I think we should try to follow the style we agreed upon. I don't know why the functions like add_u32 were not changed in #2460.
Manishearth
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The panics in this code are not new, they were in the Diplomat glue before. However, we should still remove them.Removed all panics
#2520