Implement IntoIterator for LiteMap by splitting StoreIterableMut trait #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
Manishearth,
zbraniecki and
nciric
as code owners
|
🎉 All dependencies have been resolved ! |
zbraniecki
previously approved these changes
Dec 1, 2023
Manishearth
previously approved these changes
Dec 12, 2023
|
Okay if no one is concerned about the breaking version I'll merge this Looks like there's a conflict I need to resolve. Will do that soon |
robertbastian
previously approved these changes
Feb 5, 2024
sffc
dismissed stale reviews from robertbastian, Manishearth, and zbraniecki
via
e9f2bfb
Manishearth
previously approved these changes
Feb 5, 2024
|
Added CHANGELOG entry |
Manishearth
approved these changes
Feb 5, 2024
robertbastian
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4358
It will require a breaking LiteMap version bump.