Document invariants in LocaleFallbacker #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
commented
Dec 6, 2023
| //! Watch [#2243](https://github.com/unicode-org/icu4x/issues/2243) to track improvements to | ||
| //! this algorithm and steps to enshrine the algorithm in CLDR. | ||
| //! | ||
| //! # Examples |
There was a problem hiding this comment.
This example was duplicated below.
Manishearth
reviewed
Dec 6, 2023
| /// https://github.com/unicode-org/icu4x/issues/2243) to track aligment with *UTS #35*. | ||
| /// | ||
| /// If running fallback in a loop, use [`DataLocale::is_und()`] to break from the loop. |
There was a problem hiding this comment.
what about cases where und-Script is distinct from und?
Manishearth
approved these changes
Dec 6, 2023
younies
approved these changes
Dec 7, 2023
| @@ -84,8 +58,34 @@ mod algorithms; | |||
| /// assert_eq!(fallback_iterator.get(), &locale!("und").into()); | |||
| /// ``` | |||
| /// | |||
| /// Unicode extension keywords take part in fallback, but [auxiliary keys] | |||
There was a problem hiding this comment.
Can we not put this here until aux keys are stabilized?
There was a problem hiding this comment.
I'll merge this PR because I think we agree that it is a step in the right direction given the current state of how aux keys work. Users can click the link and read that aux keys are experimental. I think we'll need to change the machinery in 2.0.
There was a problem hiding this comment.
We decided to not merge this in #4412 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #4412