Remove dep on fraction
#4459
Merged
Remove dep on fraction
#4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
sffc,
robertbastian and
a team
as code owners
younies
reviewed
Dec 14, 2023
| pub fn convert_scientific_notation_to_fraction( | ||
| number: &str, | ||
| ) -> Result<GenericFraction<BigUint>, DataError> { | ||
| pub fn convert_scientific_notation_to_fraction(number: &str) -> Result<Ratio<BigInt>, DataError> { |
There was a problem hiding this comment.
There's no need to add a dep on the num metacrate for this, and BigRational is just a typedef
There was a problem hiding this comment.
We're trying to keep dependencies low; I'm fine pulling in more num crates but we don't have to pull in all of them.
younies
reviewed
Dec 14, 2023
younies
previously approved these changes
Dec 14, 2023
Manishearth
force-pushed
the
fraction-rm
branch
from
a4c8ac5 to
f30427e
Compare
sffc
approved these changes
Dec 14, 2023
Manishearth
added a commit
to Manishearth/icu4x
that referenced
this pull request
Dec 19, 2023
Backports unicode-org#4459 Unlike that PR, this makes these deps dev-deps since they're not yet used by an experimental feature
Manishearth
added a commit
to Manishearth/icu4x
that referenced
this pull request
Dec 19, 2023
Backports unicode-org#4459 Unlike that PR, this makes these deps dev-deps since they're not yet used by an experimental feature
Manishearth
added a commit
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #3922 (comment)
Doesn't seem too complicated.
cc @younies @robertbastian