Make FormattedDateTime Copy and Clone #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
zbraniecki,
gregtatum and
nordzilla
as code owners
sffc
requested review from
Manishearth and
robertbastian
and removed request for
gregtatum and
nordzilla
Manishearth
previously approved these changes
Dec 20, 2023
|
changelog? |
|
I don't think this is harmful. In 2.0 I would like to explore keeping patterns immutable and iterating over them to compose result on-fly (rather than generating custom patterns in the constructor). This seems compatible with that approach. |
Manishearth
approved these changes
Dec 24, 2023
robertbastian
approved these changes
Jan 4, 2024
|
OK, no pushback, so I guess I'll merge this ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we want this? We don't have it currently.
Making these Copy/Clone is slightly limiting because then we can't pre-process patterns in the format function.
On the other hand, it is consistent with the ICU4X design principle of intermediate types being ephemeral and throw-away.
Please review and approve @zbraniecki @Manishearth @robertbastian