Add total_cmp
helper functions to icu_locid types and DataLocale
#4608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not implement
Ord
onLocale
orLanguageIdentifier
because there are multiple possible orderings, and we did not want to privilege one ordering over another (see #1215).We export a
strict_cmp
function that compares the receiver with a byte array. However, we do not export a function that compares the receiver to another object of the same type. This had led to issues such as #3588. I also stumbled across this today when trying to make aBTreeSet
of locales.In order to serve this use case, I added the following function to the types that needed it:
This gives us flexibility moving forward to tweak the impl or add additional comparison functions producing different orderings.