Move generic Subtag to subtags #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaking changes are not ok yet. I'm working on releasing 1.5, after which the breakage can begin. |
|
what's the ETA for 1.5? |
|
The next few days |
sffc
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch from the #1833 patchset.
It moves the
Subtagtolocid::subtags::Subtag- this is a generic subtag (2..=8, separate from private::Subtag which is 1..=8) which will be used to iterate over multi-part subtags likeextensions::unicode::Valueto retrieve specific items without relying on the underlyingTinyStrstorage.It's a breaking change because we are removing
extensions::other::Subtag. I assume this is ok as we're working on 2.0 so I don't need to add alias and deprecate it, but please confirm.