Remove icu_testdata
#4960
Merged
Remove icu_testdata
#4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
May 28, 2024
|
Someone please remove the required tag from the CI job |
Done |
sffc
approved these changes
May 29, 2024
|
|
||
| - name: Measure size of selected data package provider/testdata/data/testdata.postcard | ||
| run: | | ||
| cargo run --package icu_benchmark_binsize -- provider/testdata/data/testdata.postcard file | tee benchmarks/datasize/output.txt |
There was a problem hiding this comment.
Thought: It might be nice to run this benchmark with a postcard file generated from plain datagen, but this benchmark is not very useful because no one should be including the whole postcard file.
There was a problem hiding this comment.
We should have per-locale-per-key stats somehow, to catch things like the dictionary snafu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.