Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking filter provider #5148

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 28, 2024

There are a few things here:

  • The filters should work on DataIdentifierBorrowed instead of DataRequest; metadata should not be relevant for filtering
    • This implies a rename from RequestFilterDataProvider to FilterDataProvider
  • previously the provider implementations returned DataErrorKind::Filtered for filtered ids, however this does not work with fallback. They should return DataErrorKind::IdentiferNotFound; to a caller (like the fallback adapter) it should be opaque whether the pipeline contains a filter or not
  • filter_by_langid_allowlist_strict is marked as "will be replaced with a smarter algorithm for locale filtering". This smarter algorithm now exists, so this should be deleted (fixes Add smarter locale filtering in DataExporter #834)
  • The Filterable blanket trait adds .filterable to every type in this crate's rustdoc, and to every type in dev docs. I replaced it with a normal constructor.

@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners June 28, 2024 13:04
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward

@robertbastian robertbastian merged commit dc29c76 into unicode-org:main Jun 28, 2024
28 checks passed
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@robertbastian robertbastian deleted the errs branch July 1, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add smarter locale filtering in DataExporter
3 participants