Move baked data lookup size calculations to its exporter #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Jul 2, 2024
Manishearth
previously approved these changes
Jul 2, 2024
sffc
previously approved these changes
Jul 2, 2024
sffc
previously approved these changes
Jul 2, 2024
robertbastian
requested review from
zbraniecki,
aethanyc,
makotokato,
nciric,
nordzilla and
echeran
as code owners
robertbastian
removed request for
aethanyc,
zbraniecki,
echeran,
makotokato,
nciric and
nordzilla
|
Rebased on #5169 |
robertbastian
changed the title
sffc
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more accurate, as the previous code needed to make some educated guesses. Needed for zerotrie where we can't guess.
Based on #5169